Skip to content

chore(connection): remove TargetConnectionManager locking structures #968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

andrewazores
Copy link
Member

Welcome to Cryostat! 👋

Before contributing, make sure you have:

  • Read the contributing guidelines
  • Linked a relevant issue which this PR resolves
  • Linked any other relevant issues, PR's, or documentation, if any
  • Resolved all conflicts, if any
  • Rebased your branch PR on top of the latest upstream main branch
  • Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
  • Signed all commits using a GPG signature

To recreate commits with GPG signature git fetch upstream && git rebase --force --gpg-sign upstream/main


Fixes: #967

Description of the change:

This change allows an environment variable to be configured so that...

Motivation for the change:

This change is helpful because users may want to...

How to manually test:

  1. Run CRYOSTAT_IMAGE=quay.io... bash smoketest.bash...
  2. ...

@andrewazores andrewazores added chore Refactor, rename, cleanup, etc. safe-to-test labels Jul 4, 2025
@andrewazores
Copy link
Member Author

/build_test

Copy link

github-actions bot commented Jul 4, 2025

Workflow started at 7/3/2025, 10:53:38 PM. View Actions Run.

Copy link

github-actions bot commented Jul 4, 2025

No GraphQL schema changes detected.

Copy link

github-actions bot commented Jul 4, 2025

No OpenAPI schema changes detected.

@andrewazores
Copy link
Member Author

Seems like this might hang like we've been seeing in -core:

Runs fine locally, however. Very puzzling.

Copy link

github-actions bot commented Jul 4, 2025

CI build and push: At least one test failed ❌
https://github.com/cryostatio/cryostat/actions/runs/16064783020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Refactor, rename, cleanup, etc. safe-to-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Request] TargetConnectionManager should not rely on locking
1 participant