This repository was archived by the owner on Dec 12, 2024. It is now read-only.
Implement if/unless/elsif/else. #25
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I did this on top of #24 |
"if modifier", (return foo if bar) not yet implemented. Rules "inspired" from ruby grammar.
| 'unless', | ||
| field('condition', $._expression), | ||
| choice($._terminator, field('consequence', $.then)), | ||
| field('alternative', optional(choice($.else, $.elsif))), |
Member
There was a problem hiding this comment.
unless doesn't have elsif
| if: $ => seq( | ||
| 'if', | ||
| field('condition', $._expression), | ||
| choice($._terminator, field('consequence', $.then)), |
Member
There was a problem hiding this comment.
Do we need to save the then to a field?
Member
There was a problem hiding this comment.
Ah I guess you're using it to store the body of the if, any terminators, and the then; would recommend not putting all 3 of these together in one field if possible
Contributor
Author
|
Closing this since the repo will be archived. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"if modifier", (return foo if bar) not yet implemented.
Rules "inspired" from ruby grammar.
I think that if we finally do the assignment operator and parenthesis it will finally move us from the 0.01% pass from stdlib.