Use escape_sequence for all escape types
#115
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The grammar has several types of escape sequence nodes:
char_escape_sequence(only for chars)string_escape_sequence(everywhere else, not only for strings)ignored_backslash(used for "identity" escape sequences)This PR renames all the above to
escape_sequence. I've adjusted the highlighting as well, soescape_sequenceis always highlighted in a color that contrasts with the surrounding content.There are also line continuation backslashes, which are currently hidden nodes without any highlighting. These are unchanged. My intent here is that a line continuation looks different because it's not escaping a newline, it's obscuring a newline.
Highlighting improvements:
Before
After