Update expected failures for Crystal 1.17 #136
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nobodywasishere
approved these changes
Sep 9, 2025
Collaborator
Author
|
@nobodywasishere I was gonna wait until the test run actually passed on Github, lol |
Member
|
Oh lol we should update the rules then to require passing CI |
Collaborator
Author
Member
|
Updated the rules, generate and test are required to pass (but can be bypassed if necessary) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pthread.cr failures uncovered a parsing issue with proc type parameters in fun definitions. Getting that fixed properly has turned into a precedence whack-a-mole game, so I'm just adding a TODO for now.