Install foundry on the container if required#8
Merged
Conversation
If the target is a directory and it contains a foundry.toml file, install foundry using foundryup before invoking slither. Also run foundry install to gather any required dependencies. Fixes: #5
gakonst
approved these changes
May 9, 2022
| echo "[-] Foundry target detected, installing foundry nightly" | ||
|
|
||
| wget -q -O foundryup https://raw.githubusercontent.com/foundry-rs/foundry/36a66c857ff148f6ed007cdcd3402077de3595cf/foundryup/foundryup | ||
| if [ ! "c0c6711dc39deae65bebcc0320fec1265930895a527e18daa643a708218c07ae foundryup" = "$(sha256sum foundryup)" ]; then |
Member
Author
|
@gakonst it's missing a way to pass a different foundry version -- I saw the foundry action offers an option to change that; how important do you reckon it is to have something like that in the Slither action? We can always add it later if it's non-urgent. |
|
I think it's not really urgent, we've had a culture of using nightlies for the most part for Foundry so I'd say let's go ahead, and iterate, given it'd unblock the action from being used in 3rd party CI (like here) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the target is a directory and it contains a foundry.toml file,
install foundry using foundryup before invoking slither. Also run
foundry install to gather any required dependencies.
Fixes: #5