Skip to content

Install foundry on the container if required #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 11, 2022
Merged

Conversation

elopez
Copy link
Member

@elopez elopez commented Apr 28, 2022

If the target is a directory and it contains a foundry.toml file,
install foundry using foundryup before invoking slither. Also run
foundry install to gather any required dependencies.

Fixes: #5

If the target is a directory and it contains a foundry.toml file,
install foundry using foundryup before invoking slither. Also run
foundry install to gather any required dependencies.

Fixes: #5
Copy link

@gakonst gakonst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - anything else needed to get this over the line?

echo "[-] Foundry target detected, installing foundry nightly"

wget -q -O foundryup https://raw.githubusercontent.com/foundry-rs/foundry/36a66c857ff148f6ed007cdcd3402077de3595cf/foundryup/foundryup
if [ ! "c0c6711dc39deae65bebcc0320fec1265930895a527e18daa643a708218c07ae foundryup" = "$(sha256sum foundryup)" ]; then
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@elopez
Copy link
Member Author

elopez commented May 9, 2022

@gakonst it's missing a way to pass a different foundry version -- I saw the foundry action offers an option to change that; how important do you reckon it is to have something like that in the Slither action? We can always add it later if it's non-urgent.

@gakonst
Copy link

gakonst commented May 9, 2022

I think it's not really urgent, we've had a culture of using nightlies for the most part for Foundry so I'd say let's go ahead, and iterate, given it'd unblock the action from being used in 3rd party CI (like here)

@elopez elopez marked this pull request as ready for review May 9, 2022 17:22
gakonst added a commit to foundry-rs/forge-template that referenced this pull request May 9, 2022
@montyly montyly merged commit aa18757 into main May 11, 2022
@montyly montyly deleted the dev-install-foundry branch May 11, 2022 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Install foundry in the container
3 participants