Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dotnet format checking in CI #30

Closed
wants to merge 8 commits into from
Closed

Dotnet format checking in CI #30

wants to merge 8 commits into from

Conversation

henneboy
Copy link

@henneboy henneboy commented Oct 31, 2024 •
edited
Loading

This should add CI which checks if the code is formatted. To format the code run dotnet format MAEPS.sln
Closes #23

Casper-NS
Casper-NS previously approved these changes Oct 31, 2024
View reviewed changes
Copy link
Member

@Casper-NS Casper-NS left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have a look at the build, it fails on restore. I think you need to specify the project

@henneboy
Copy link
Author

Tak @Casper-NS but it doesn't work, and ideas on how to fix, I just copy+paste+edit from very old project by @mads256h :)

@Casper-NS Casper-NS self-requested a review October 31, 2024 10:49
@henneboy henneboy changed the title Create dotnet.yml Dotnet format checking in CI Nov 1, 2024
@henneboy henneboy marked this pull request as draft November 1, 2024 13:26
@henneboy henneboy closed this Nov 6, 2024
@henneboy henneboy deleted the linting-ci branch November 6, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Casper-NS Casper-NS Awaiting requested review from Casper-NS

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Setup C# linting CI
2 participants
@henneboy @Casper-NS