Skip to content

Big Cucumber PR #299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 26 commits into from
May 9, 2025
Merged

Big Cucumber PR #299

merged 26 commits into from
May 9, 2025

Conversation

yamyoume
Copy link

@yamyoume yamyoume commented May 8, 2025

General Info

  • Generating test data using Factory Bot
  • custom_steps.rb 1 set up step that creates a course, settings, assignments, and users, as well as several general steps with comments on what they do and how to use them, as well as several Stubbing steps to go around API calls
  • Changed the default cucumber running setting not to run "time-wasting" @Skipped scenarios
  • fixed incorrect date format in requests/new.html.erb (found by testing)
  • added @visible-browser tag in feature/support/env.rb for running tests in a browser window (it doesn't work btw | ∞ redirects)
  • created several Features with multiple scenarios:
    • assignments.feature
    • course_settings.feature
    • enrollments.feature
    • form_settings.feature
    • requests.feature
  • fixed some a11y violations that popped up in some views

Issues:

Resolved #170
Resolved #171
Resolved #229

yamyoume added 26 commits April 12, 2025 22:13
Copy link

@huanger2 huanger2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, FINAL PR :)

@huanger2 huanger2 merged commit ad0afab into main May 9, 2025
12 checks passed
@huanger2 huanger2 deleted the cucumber branch May 9, 2025 02:38
@yamyoume
Copy link
Author

yamyoume commented May 9, 2025

LGTM, FINAL PR :)
with Cucumber set up, now we can finally do T.D.D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants