Skip to content

Add mass approve/decline UI and backend batch actions (#326, #327)#330

Open
ba88im wants to merge 89 commits intomainfrom
mass-approve-decline
Open

Add mass approve/decline UI and backend batch actions (#326, #327)#330
ba88im wants to merge 89 commits intomainfrom
mass-approve-decline

Conversation

@ba88im
Copy link

@ba88im ba88im commented Mar 6, 2026 •
edited by gobears01
Loading

General Info

Allow course staff member to mass select and approve/deny requests manually. Also, allow approve/deny requests without refreshing the whole page because that is slow.
To complete this tasks. We divided work into 3 user stories:
1. Make approve / reject be AJAX request and refresh the table instead of the whole page like the current HTTP request / form submission

2. Create the UI checkboxes to select multiple extensions and potentially an option to mass select

3. Update backend to allow mass auto or mass decline

Summary

  • Added checkbox-based multi-select UI to the instructor requests table.
  • Added Approve Selected and Reject Selected batch actions.
  • Added backend mass_approve and mass_reject endpoints returning JSON for AJAX updates.
  • Updated the Stimulus requests controller to support select-all, row selection, and batch updates (including DataTable redraws).
  • Removed the hardcoded export host and made request-link generation environment-safe.

Testing

  • Added Rspec for approve/ reject AJAX
  • Aded controller specs covering batch approve/reject flows.

gobears01 and others added 4 commits March 4, 2026 20:55
@gobears01
Made approve / reject be AJAX request and refresh the table.
56c9477
@ba88im
Add mass approve/reject UI + backend actions (#326, #327)
cd68bb7 
- Add row/select-all checkboxes and batch approve/reject buttons in instructor requests table

- Add mass_approve and mass_reject routes + controller actions with JSON responses

- Extend Stimulus controller for batch selection/action handling with DataTable updates

- Add controller specs for mass endpoints

- Remove hardcoded export host and build environment-safe request links
@ba88im
Fix CI lint and spec issues for mass actions
61472d9 
- align multi-line message assignment for RuboCop

- update controller specs to use response.parsed_body and contain_exactly

- use class_double for CanvasFacade.from_user stubbing
@gobears01
Added tests for AJAX implementation
088d0b9
@gobears01
Copy link

gobears01 commented Mar 10, 2026

Dear Professor @armandofox,

Basim and I have added the feature to mass approve/ deny requests manually and changed approve/deny to AJAX instead of full page reload per this golden repo feature request and your review is appreciated.

Sincerely,

Anthony Dam

@gobears01 gobears01 requested a review from armandofox March 10, 2026 01:10
gobears01 and others added 20 commits March 16, 2026 19:29
@gobears01
Combined Igor UI changes
d09688b
@gobears01
Swapped name and assignment columns, added link to request
912cfd5
@dependabot @gobears01
Bump puma from 7.1.0 to 7.2.0
9d54d77 
Bumps [puma](https://github.com/puma/puma) from 7.1.0 to 7.2.0.
- [Release notes](https://github.com/puma/puma/releases)
- [Changelog](https://github.com/puma/puma/blob/main/History.md)
- [Commits](puma/puma@v7.1.0...v7.2.0)

---
updated-dependencies:
- dependency-name: puma
  dependency-version: 7.2.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot @gobears01
Bump bootsnap from 1.20.1 to 1.21.1
25440d9 
Bumps [bootsnap](https://github.com/rails/bootsnap) from 1.20.1 to 1.21.1.
- [Release notes](https://github.com/rails/bootsnap/releases)
- [Changelog](https://github.com/rails/bootsnap/blob/main/CHANGELOG.md)
- [Commits](rails/bootsnap@v1.20.1...v1.21.1)

---
updated-dependencies:
- dependency-name: bootsnap
  dependency-version: 1.21.1
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot @gobears01
Bump pg from 1.6.2 to 1.6.3
130dcf0 
Bumps [pg](https://github.com/ged/ruby-pg) from 1.6.2 to 1.6.3.
- [Changelog](https://github.com/ged/ruby-pg/blob/master/CHANGELOG.md)
- [Commits](ged/ruby-pg@v1.6.2...v1.6.3)

---
updated-dependencies:
- dependency-name: pg
  dependency-version: 1.6.3
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@cycomachead @gobears01
Add a /help redirect, move some routes around
2d2df34
@cycomachead @gobears01
Allow overriding PORT
d7d3f5a
@cycomachead @gobears01
Gradescope note
6fa8036
@cycomachead @gobears01
improved GS user copy
21ab42f
@cycomachead @gobears01
gitignore
2bfee06
@dependabot @gobears01
Bump sentry-rails from 6.2.0 to 6.3.0
46e180c 
Bumps [sentry-rails](https://github.com/getsentry/sentry-ruby) from 6.2.0 to 6.3.0.
- [Release notes](https://github.com/getsentry/sentry-ruby/releases)
- [Changelog](https://github.com/getsentry/sentry-ruby/blob/master/CHANGELOG.md)
- [Commits](getsentry/sentry-ruby@6.2.0...6.3.0)

---
updated-dependencies:
- dependency-name: sentry-rails
  dependency-version: 6.3.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot @gobears01
Bump axe-core-cucumber from 4.11.0 to 4.11.1
7901b6d 
Bumps [axe-core-cucumber](https://github.com/dequelabs/axe-core-gems) from 4.11.0 to 4.11.1.
- [Release notes](https://github.com/dequelabs/axe-core-gems/releases)
- [Changelog](https://github.com/dequelabs/axe-core-gems/blob/develop/CHANGELOG.md)
- [Commits](dequelabs/axe-core-gems@v4.11.0...v4.11.1)

---
updated-dependencies:
- dependency-name: axe-core-cucumber
  dependency-version: 4.11.1
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot @gobears01
Bump bootstrap from 5.3.5 to 5.3.8
c0b1dd2 
Bumps [bootstrap](https://github.com/twbs/bootstrap-rubygem) from 5.3.5 to 5.3.8.
- [Release notes](https://github.com/twbs/bootstrap-rubygem/releases)
- [Changelog](https://github.com/twbs/bootstrap-rubygem/blob/main/CHANGELOG.md)
- [Commits](twbs/bootstrap-rubygem@v5.3.5...v5.3.8)

---
updated-dependencies:
- dependency-name: bootstrap
  dependency-version: 5.3.8
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot @gobears01
Bump turbo-rails from 2.0.21 to 2.0.23
85b270e 
Bumps [turbo-rails](https://github.com/hotwired/turbo-rails) from 2.0.21 to 2.0.23.
- [Release notes](https://github.com/hotwired/turbo-rails/releases)
- [Commits](hotwired/turbo-rails@v2.0.21...v2.0.23)

---
updated-dependencies:
- dependency-name: turbo-rails
  dependency-version: 2.0.23
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot @gobears01
Bump rubocop from 1.82.1 to 1.84.2
2c3b5a5 
Bumps [rubocop](https://github.com/rubocop/rubocop) from 1.82.1 to 1.84.2.
- [Release notes](https://github.com/rubocop/rubocop/releases)
- [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md)
- [Commits](rubocop/rubocop@v1.82.1...v1.84.2)

---
updated-dependencies:
- dependency-name: rubocop
  dependency-version: 1.84.2
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot @gobears01
Bump bootsnap from 1.21.1 to 1.23.0
fc075bb 
Bumps [bootsnap](https://github.com/rails/bootsnap) from 1.21.1 to 1.23.0.
- [Release notes](https://github.com/rails/bootsnap/releases)
- [Changelog](https://github.com/rails/bootsnap/blob/main/CHANGELOG.md)
- [Commits](rails/bootsnap@v1.21.1...v1.23.0)

---
updated-dependencies:
- dependency-name: bootsnap
  dependency-version: 1.23.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot @gobears01
Bump sentry-ruby from 6.3.0 to 6.3.1
f9b895f 
Bumps [sentry-ruby](https://github.com/getsentry/sentry-ruby) from 6.3.0 to 6.3.1.
- [Release notes](https://github.com/getsentry/sentry-ruby/releases)
- [Changelog](https://github.com/getsentry/sentry-ruby/blob/master/CHANGELOG.md)
- [Commits](getsentry/sentry-ruby@6.3.0...6.3.1)

---
updated-dependencies:
- dependency-name: sentry-ruby
  dependency-version: 6.3.1
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot @gobears01
Bump annotaterb from 4.20.0 to 4.22.0
9208b4e 
Bumps [annotaterb](https://github.com/drwl/annotaterb) from 4.20.0 to 4.22.0.
- [Changelog](https://github.com/drwl/annotaterb/blob/main/CHANGELOG.md)
- [Commits](drwl/annotaterb@v4.20.0...v4.22.0)

---
updated-dependencies:
- dependency-name: annotaterb
  dependency-version: 4.22.0
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot @gobears01
Bump faraday in the bundler group across 1 directory
a435169 
Bumps the bundler group with 1 update in the / directory: [faraday](https://github.com/lostisland/faraday).


Updates `faraday` from 2.14.0 to 2.14.1
- [Release notes](https://github.com/lostisland/faraday/releases)
- [Changelog](https://github.com/lostisland/faraday/blob/main/CHANGELOG.md)
- [Commits](lostisland/faraday@v2.14.0...v2.14.1)

---
updated-dependencies:
- dependency-name: faraday
  dependency-version: 2.14.1
  dependency-type: direct:production
  dependency-group: bundler
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot @gobears01
Bump brakeman from 7.1.2 to 8.0.2
5181fd6 
Bumps [brakeman](https://github.com/presidentbeef/brakeman) from 7.1.2 to 8.0.2.
- [Release notes](https://github.com/presidentbeef/brakeman/releases)
- [Changelog](https://github.com/presidentbeef/brakeman/blob/main/CHANGES.md)
- [Commits](presidentbeef/brakeman@v7.1.2...v8.0.2)

---
updated-dependencies:
- dependency-name: brakeman
  dependency-version: 8.0.2
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
cycomachead and others added 30 commits March 17, 2026 17:50
@cycomachead @gobears01
tidy docs, add DOI info
08c4bc5
@cycomachead @gobears01
more updates
11034a9
@ba88im @gobears01
Add project info.yml metadata
d11d44e
@alxstx @gobears01
Add tests for enrollments-to-requests search filter
8b05efa
@alxstx @gobears01
Add step definitions and test data for enrollments-to-requests
3b9382e 
  filter test
@dependabot @gobears01
Bump brakeman from 8.0.2 to 8.0.4
01dc86f 
Bumps [brakeman](https://github.com/presidentbeef/brakeman) from 8.0.2 to 8.0.4.
- [Release notes](https://github.com/presidentbeef/brakeman/releases)
- [Changelog](https://github.com/presidentbeef/brakeman/blob/main/CHANGES.md)
- [Commits](presidentbeef/brakeman@v8.0.2...v8.0.4)

---
updated-dependencies:
- dependency-name: brakeman
  dependency-version: 8.0.4
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@cycomachead @gobears01
Update a bunch of smaller dependencies for testing, etc
22ef95f
@cycomachead @gobears01
update sentry
f7c7b07
@cycomachead @gobears01
bump rubocop-rails and delint
4adc27b
@cycomachead @gobears01
bump rubocop-rspec and delint
0f4e560
@cycomachead @gobears01
bump mail gem
31fa074
@cycomachead @gobears01
bundle update guard / deps
333419b
@cycomachead @gobears01
bump globalid
114efed
@cycomachead @gobears01
Minor transitive deps updates
036cd72
@cycomachead @gobears01
More transitive deps updates
5606c16
@dependabot @gobears01
Bump the npm_and_yarn group across 1 directory with 2 updates
73a1b96 
Bumps the npm_and_yarn group with 2 updates in the / directory: [fast-xml-parser](https://github.com/NaturalIntelligence/fast-xml-parser) and [minimatch](https://github.com/isaacs/minimatch).


Updates `fast-xml-parser` from 5.3.6 to 5.4.1
- [Release notes](https://github.com/NaturalIntelligence/fast-xml-parser/releases)
- [Changelog](https://github.com/NaturalIntelligence/fast-xml-parser/blob/master/CHANGELOG.md)
- [Commits](NaturalIntelligence/fast-xml-parser@v5.3.6...v5.4.1)

Updates `minimatch` from 10.1.1 to 10.2.4
- [Changelog](https://github.com/isaacs/minimatch/blob/main/changelog.md)
- [Commits](isaacs/minimatch@v10.1.1...v10.2.4)

Updates `minimatch` from 5.1.6 to 5.1.9
- [Changelog](https://github.com/isaacs/minimatch/blob/main/changelog.md)
- [Commits](isaacs/minimatch@v10.1.1...v10.2.4)

---
updated-dependencies:
- dependency-name: fast-xml-parser
  dependency-version: 5.4.1
  dependency-type: indirect
  dependency-group: npm_and_yarn
- dependency-name: minimatch
  dependency-version: 10.2.4
  dependency-type: indirect
  dependency-group: npm_and_yarn
- dependency-name: minimatch
  dependency-version: 5.1.9
  dependency-type: indirect
  dependency-group: npm_and_yarn
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot @gobears01
Bump dompurify in the npm_and_yarn group across 1 directory
2b68ba7 
Bumps the npm_and_yarn group with 1 update in the / directory: [dompurify](https://github.com/cure53/DOMPurify).


Updates `dompurify` from 3.3.0 to 3.3.2
- [Release notes](https://github.com/cure53/DOMPurify/releases)
- [Commits](cure53/DOMPurify@3.3.0...3.3.2)

---
updated-dependencies:
- dependency-name: dompurify
  dependency-version: 3.3.2
  dependency-type: indirect
  dependency-group: npm_and_yarn
...

Signed-off-by: dependabot[bot] <[email protected]>
@gobears01
Added the changes per prof Ball requests
38841d1
@cycomachead @gobears01
delint
5acc7b2
@cycomachead @gobears01
Rename README to make docs more clear
9cfbbb3
@cycomachead @gobears01
Setup local github pages in docs directory
d2ae5c3
@cycomachead @gobears01
WIP tidy docs
099d3ea
@cycomachead @gobears01
minor README tweaks
9cd9d31
@cycomachead @gobears01
Fix some small issues
63a1380
@cycomachead @gobears01
Add environment variable to docs build
7e0e8d1
@cycomachead @gobears01
More docs updates
4f9ef23
@dependabot @gobears01
Bump undici in the npm_and_yarn group across 1 directory
3ff2c32 
Bumps the npm_and_yarn group with 1 update in the / directory: [undici](https://github.com/nodejs/undici).


Updates `undici` from 6.22.0 to 6.24.0
- [Release notes](https://github.com/nodejs/undici/releases)
- [Commits](nodejs/undici@v6.22.0...v6.24.0)

---
updated-dependencies:
- dependency-name: undici
  dependency-version: 6.24.0
  dependency-type: indirect
  dependency-group: npm_and_yarn
...

Signed-off-by: dependabot[bot] <[email protected]>
@cycomachead @gobears01
Run bundle update --minor
15e185c
@gobears01
Moved approve/ reject selected buttons to the bottom of the requests …
6f55b2d 
…table
@gobears01
Moved Approve/ Reject Selected buttons to the left, changed checkboxe…
fb80739 
…s UI to toggles to match course settings toggles
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alxstx alxstx Awaiting requested review from alxstx

@Shklalom Shklalom Awaiting requested review from Shklalom

@noahnizamian noahnizamian Awaiting requested review from noahnizamian

@armandofox armandofox Awaiting requested review from armandofox

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@ba88im @gobears01 @cycomachead @dg-ucb @brandosu @alxstx