fix: cephmount: call GetQuota on received path, not on root #5486
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
labkode
commented
Jan 23, 2026
labkode
commented
- Calls GetQuota on the passed path vs the root mountpoint.
- Remove unused function.
labkode
requested review from
diocas,
glpatcern,
jessegeens and
rawe0
as code owners
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
glpatcern
requested changes
Jan 23, 2026
Member
glpatcern
left a comment
glpatcern
left a comment
There was a problem hiding this comment.
Thanks Hugo, just reporting here the comment in the chat
Comment on lines
+1010
to
+1012
| maxQuotaData, err := xattr.Get(fullPath, "ceph.quota.max_bytes") | ||
| if err != nil { | ||
| log.Debug().Msg("cephmount: user.quota.max_bytes xattr not set, using default") | ||
| log.Debug().Msg("cephmount: ceph.quota.max_bytes xattr not set, using default") |
Member
There was a problem hiding this comment.
So here we should traverse the tree to the top, looking for quota attributes and return the lowest value, defaulting to the whole mount only if none is found, right?
Member
There was a problem hiding this comment.
And even if we go for a basic approach with no hierarchy of quotas (which I think it's fine), how do we know which node of the path holds the attribute? Or is this function only called at the root of the "Space"? cc @jessegeens
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.