Skip to content

Add automatic upload to npm #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jun 16, 2025
Merged

Add automatic upload to npm #72

merged 7 commits into from
Jun 16, 2025

Conversation

koplas
Copy link
Contributor

@koplas koplas commented Jun 10, 2025

To allow automatic uploads, the secret token needs to be configured:
Settings → Secrets → Actions → New repository secret with name NPM_TOKEN.

@koplas koplas requested a review from cintek June 10, 2025 08:24
Copy link

github-actions bot commented Jun 10, 2025

Coverage Report

Status Category Percentage Covered / Total
🟢 Lines 88.13% (🎯 60%) 208 / 236
🟢 Statements 87.64% (🎯 60%) 234 / 267
🟢 Functions 94.33% (🎯 60%) 50 / 53
🟢 Branches 84.56% (🎯 60%) 137 / 162
File CoverageNo changed files found.
Generated in workflow #86 for commit f7b7159 by the Vitest Coverage Report Action

@koplas koplas linked an issue Jun 10, 2025 that may be closed by this pull request
@koplas
Copy link
Contributor Author

koplas commented Jun 10, 2025

Pinging @mfd2007 for token configuration.

Copy link
Contributor

@tschmidtb51 tschmidtb51 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see my comments

@tschmidtb51 tschmidtb51 assigned tschmidtb51 and unassigned mfd2007 Jun 10, 2025
koplas and others added 2 commits June 10, 2025 19:24
@koplas
Copy link
Contributor Author

koplas commented Jun 13, 2025

@tschmidtb51 I invited you as a maintainer for the csaf-webview npm package.

@tschmidtb51
Copy link
Contributor

@koplas I suggest to use the scoped package instead of the unscoped... Please replace the unscoped with something similar to https://www.npmjs.com/package/csaf-validator-lib

Token is read and installed

tschmidtb51
tschmidtb51 previously approved these changes Jun 13, 2025
Copy link
Contributor

@tschmidtb51 tschmidtb51 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@cintek cintek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cintek cintek merged commit 3f640e9 into main Jun 16, 2025
4 checks passed
@cintek cintek deleted the npm-action branch June 16, 2025 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Entry for yarnpkg.com & npm registry
4 participants