Skip to content

Examples #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 18, 2025
Merged

Examples #77

merged 3 commits into from
Jun 18, 2025

Conversation

JanHoefelmeyer
Copy link
Contributor

Solves #75

TODO: Better example feeds/advisories/PMDs

Copy link

github-actions bot commented Jun 12, 2025

Coverage Report

Status Category Percentage Covered / Total
🟢 Lines 88.13% (🎯 60%) 208 / 236
🟢 Statements 87.64% (🎯 60%) 234 / 267
🟢 Functions 94.33% (🎯 60%) 50 / 53
🟢 Branches 84.56% (🎯 60%) 137 / 162
File CoverageNo changed files found.
Generated in workflow #90 for commit 19cb240 by the Vitest Coverage Report Action

@JanHoefelmeyer
Copy link
Contributor Author

Design decisions:

  • Used intevations provider-metadata.json and advisory to prevent issues with CORS restrictions that happen e.g. on trying to load https://wid.cert-bund.de/.well-known/csaf/provider-metadata.json
  • The advisory cannot be loaded on the dev build, most likely due to the proxy used (which is worth a consideration on whether this is even a good thing)? (The load leads to a 404)
  • Button only loads the url into the url finder to prevent accidentally overwriting what you are currently reading at the press of a singular button.

@JanHoefelmeyer JanHoefelmeyer marked this pull request as ready for review June 18, 2025 13:22
@JanHoefelmeyer JanHoefelmeyer requested a review from cintek June 18, 2025 13:22
Copy link
Contributor

@cintek cintek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM & works

@cintek cintek merged commit 750222e into main Jun 18, 2025
4 checks passed
@koplas koplas deleted the Examples branch June 18, 2025 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants