controllers: fix decommission stuck when pod is deleted #185
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a Cassandra pod is deleted during decommission (e.g., StatefulSet scaled down manually), casskop gets stuck in StatusOngoing state because it tries to get a non-existent pod and returns an error instead of transitioning to StatusFinalizing for PVC cleanup. This fix handles the IsNotFound error case during StatusOngoing by transitioning to StatusFinalizing and proceeding with PVC cleanup, similar to how StatusFinalizing already handles this case. The fix ensures casskop can properly recover when pods are deleted during decommission operations, allowing the cluster to scale correctly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a Cassandra pod is deleted during decommission (e.g., StatefulSet scaled down manually), casskop gets stuck in StatusOngoing state because it tries to get a non-existent pod and returns an error instead of transitioning to StatusFinalizing for PVC cleanup.
This fix handles the IsNotFound error case during StatusOngoing by transitioning to StatusFinalizing and proceeding with PVC cleanup, similar to how StatusFinalizing already handles this case.
The fix ensures casskop can properly recover when pods are deleted during decommission operations, allowing the cluster to scale correctly.
What's in this PR?
Why?
Additional context
Checklist
To Do