Skip to content

Simple CSV Import #575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from

Conversation

henninggaertner
Copy link
Collaborator

@henninggaertner henninggaertner commented Feb 27, 2025

Description

fixes #573
Adds new method for importing proteomic data using a csv with a specified format.
Also runs black on the changed files, which unfortunately also changes formatting in different parts of the code.

Changes

The usual files when adding a new import method, see changes. Also added a comment for a related issue #574 and tests.

Testing

For example, pull one of the csvs added for testing and try to import it. The format should be the same as it would be for example for maxquant data.

PR checklist

Development

  • If necessary, I have updated the documentation (README, docstrings, etc.)
  • If necessary, I have created / updated tests.

Mergeability

  • main-branch has been merged into local branch to resolve conflicts
  • The tests and linter have passed AFTER local merge
  • The code has been formatted with black

Code review

  • I have self-reviewed my code.
  • At least one other developer reviewed and approved the changes

@henninggaertner henninggaertner linked an issue Feb 27, 2025 that may be closed by this pull request
3 tasks
Copy link

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  protzilla
  disk_operator.py
  run.py
  run_helper.py
  steps.py 79-80, 154
  protzilla/data_analysis
  plots.py
  protein_graphs.py
  ptm_analysis.py 56, 123-125
  protzilla/data_integration
  database_query.py 113-119
  di_plots.py
  protzilla/data_preprocessing
  outlier_detection.py
  plots.py
  protzilla/importing
  ms_data_import.py 122, 178, 189-190, 193, 195, 203, 211, 327, 337
  protzilla/methods
  data_analysis.py 21, 174, 250, 283, 308, 351, 916, 935
  data_preprocessing.py
  importing.py 67-68, 74, 160
  protzilla/utilities
  utilities.py 184
  ui/main
  settings.py 131
  ui/runs
  fields.py
  views.py 21, 72-73, 185, 262, 712, 717-721
  ui/runs/forms
  base.py 107
  custom_fields.py 119
  data_analysis.py 323-327, 384, 414, 450, 473, 1188, 1226, 1248
  data_integration.py
  importing.py
  ui/settings
  plot_template.py 84
Project Total  

The report is truncated to 25 files out of 62. To see the full report, please visit the workflow summary page.

This report was generated by python-coverage-comment-action

@henninggaertner henninggaertner marked this pull request as draft February 27, 2025 12:54
@henninggaertner henninggaertner marked this pull request as ready for review February 27, 2025 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Importing a simple CSV of protein data
1 participant