Implement valkey backend #460
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DerkSchooltink
force-pushed
the
feature/implement-valkey-backend
branch
2 times, most recently
from
f20d64a to
96a6b63
Compare
Author
|
Before I undraft this, I will attempt to run this in a private project to see if I missed anything. The queue tests should cover the majority and they seem to work fine, but there are some key differences inside Dequeue and Size that I'm not entirely sure of. |
DerkSchooltink
force-pushed
the
feature/implement-valkey-backend
branch
3 times, most recently
from
38ef7ff to
3a48b8e
Compare
DerkSchooltink
force-pushed
the
feature/implement-valkey-backend
branch
from
e63ccd8 to
4fafa8c
Compare
Author
|
re-authored all commits to stop using my other git account :) |
…er-mode)" This reverts commit 534b23f.
…when no instance is found in the workflow
DerkSchooltink
force-pushed
the
feature/implement-valkey-backend
branch
from
c7c2148 to
f85e196
Compare
Author
|
To sum up, this is basically a carbon copy of the Redis backend implementation. I've actually tested the Redis backend with a Valkey server, and it actually works as far as I can see. But obviously, guaranteeing that compatibility might not hold forever. Hence, a valkey-go SDK implementation to go alongside the Redis variant. |
Author
|
@cschleiden could I get your eyes on this please? :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implements #363