Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Initial design v2 #3

Draft
wants to merge 29 commits into
base: main
Choose a base branch
from
Draft

WIP: Initial design v2 #3

wants to merge 29 commits into from

Conversation

cserteGT3
Copy link
Owner

@cserteGT3 cserteGT3 commented Jul 6, 2023 •
edited
Loading

I needed to rethink the design of the package, which makes #1 obsolete.
The todos copied from there:

  • implement evaluation for HybridProblems: 2a8a401
  • separate geometries and optimization problem: 5fa9b71
  • abstract type for optimization problem?
  • LocalizationFeature should be a concrete type? -> yes close LocalizationFeature should be concrete type? #19
  • handle machined-rough tolerances (industry "standard" says: one point, that one point should be returned) - with dc722c0 the current needs are implemented
  • tests, tests, tests
  • vizualization in package extension
  • transition to using Meshes.Points, etc. (probably later in Transition to Meshes.jl types #6)
  • API documentation
    • test API with pointcloud implementation?
    • what is exported, what is not?

@cserteGT3 cserteGT3 mentioned this pull request Jul 13, 2023
Merged
9 tasks
@cserteGT3
Copy link
Owner Author

This will be the way, but a bit later.

@cserteGT3 cserteGT3 changed the title Initial design v2 Draft: Initial design v2 Jul 13, 2023
@cserteGT3 cserteGT3 changed the title Draft: Initial design v2 WIP: Initial design v2 Jul 13, 2023
@cserteGT3 cserteGT3 marked this pull request as draft July 13, 2023 08:54
@cserteGT3 cserteGT3 mentioned this pull request Sep 7, 2023
Open
@cserteGT3
Copy link
Owner Author

The main task or question is: how to not implement twice the tolerance and allowance evaluations. The evaluation should happen with evaluating the jump model. But I don't yet know how to do that.

@cserteGT3
Copy link
Owner Author

cserteGT3 commented Jan 17, 2024 •
edited
Loading

Picking up where I left it, my current goals are:

  • use the JuMP model for evaluation (thus not implement everything twice)
  • rethink the tolerance abstraction based on our current understanding and goals (and document it thoroughly)
  • update to latest Meshes.jl
  • update github CI to v2?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

LocalizationFeature should be concrete type?
1 participant
@cserteGT3