Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial design #1

Merged
merged 31 commits into from
Jul 19, 2023
Merged

Initial design #1

merged 31 commits into from
Jul 19, 2023

Conversation

cserteGT3
Copy link
Owner

@cserteGT3 cserteGT3 commented Jun 29, 2023

Source initial code from internal repository.

Todo list:

  • implement evaluation for HybridProblems: 2a8a401
  • separate geometries and optimization problem -> moved to WIP: Initial design v2 #3
  • abstract type for optimization problem? -> not necessary right now
  • handle machined-rough tolerances (industry "standard" says: one point, that one point should be returned) -> moved to WIP: Initial design v2 #3
  • tests, tests, tests
  • vizualization in package extension not the purpose of package extensions
  • API documentation

@cserteGT3 cserteGT3 mentioned this pull request Jul 6, 2023
11 tasks
@cserteGT3
Copy link
Owner Author

Closing as superseded by #2

@cserteGT3 cserteGT3 closed this Jul 6, 2023
@cserteGT3 cserteGT3 reopened this Jul 13, 2023
@cserteGT3
Copy link
Owner Author

#3 has advantages:

  • defining different types of tolerances
  • tolerances can kinda handle primitive and freeform geometries

But it would much work to finish and also there are some pretty rough edges, therefore I am planning to release this version first, then will work on those details later.

@cserteGT3
Copy link
Owner Author

I tought that I should do the visualization with package extensions, but I realized that it is not for this purpose. My next idea, that I have a set of functions like:

  • generateroughholes(mop)
  • generatemachinedholes(mop)
  • etc.

And those return Meshes.jl objects, that can be then visualized with Meshviz.jl

@cserteGT3
Copy link
Owner Author

I am finished with the first version of the package, should be released as v0.1.0.

@cserteGT3 cserteGT3 merged commit 708514b into main Jul 19, 2023
@cserteGT3 cserteGT3 deleted the initial-design branch July 19, 2023 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant