get_intensity_cut behavior #1364
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Until now, if finding of the intensity peak failed, a log message was shown telling so, but the returned value was 50 p.e. Besides, another message was shown indicating that 50 p.e. was an adequate cut for the run... So it was confusing. This was just due to the behaviour of the max function when the second argument is nan. Now in case the peak is not found the function returns nan. It should however happen rarely.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1364 +/- ##
=======================================
Coverage 72.65% 72.65%
=======================================
Files 137 137
Lines 14559 14559
=======================================
Hits 10578 10578
Misses 3981 3981 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until now, if finding of the intensity peak failed, a log message was shown telling so, but the returned value was 50 p.e. Besides, another message was shown indicating that 50 p.e. was an adequate cut for the run... So it was confusing.
This was just due to the behaviour of the max function when the second argument is nan. Now, in case the peak is not found, the function returns nan. This should however happen rarely.