Muon parameters update

[jstvdk]

I added new functionality to the muon analysis as described in the Issue #2665 , specifically

• new fields to the MuonParametersContainer
• new methods to the ctapipe/image/muon/features.py
• new tests for above mentioned methods in ctapipe/image/muon/tests/test_muon_features.py
• additional code block in ctapipe/image/muon/processor.py to process and save new muon parameters

Added changes mainly follow existing code in lstchain/image/muon/muon_analysis.py, with one exception:

• I redefined the variable num_pixels_in_ring - now it takes into account only pixels that survived the cleaning, contrary to what currently implemented in lstchain, where this variable contains all pixels inside the geometrical area of the ring.

Closes #2665

[maxnoe]

Hi @jstvdk

Thanks a lot for preparing this. This looks like a good starting point. I have a couple of first comments mainly about the names of the fields and their descriptions.

I will do second round on more technical issues of the code later.

[mexanick]

docs are failing due to an issue with the type hint resolution with a few similar warnings:

/home/runner/work/ctapipe/ctapipe/src/ctapipe/image/muon/features.py:docstring of ctapipe.image.muon.features.intensity_ratio_inside_ring:1: WARNING: py:class reference target not found: ctapipe.containers.MuonRingContainer [ref.class]

@maxnoe any idea how to fix it (apart from adding more ctapipe-related stuff in nitpick_ignore_regex?

[maxnoe]

Is the MuonRingContainer present in __all__ in containers.py?

[ctao-dpps-sonarqube]

Analysis Details

0 Issues

• 0 Bugs
• 0 Vulnerabilities
• 0 Code Smells

Coverage and Duplications

• 99.10% Coverage (93.70% Estimated after merge)
• 0.00% Duplicated Code (0.70% Estimated after merge)

Project ID: cta-observatory_ctapipe_AY52EYhuvuGcMFidNyUs

View in SonarQube

Changes implemented