Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Store event times using CTAO high resolution timestamps #2707

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Store event times using CTAO high resolution timestamps #2707

wants to merge 6 commits into from

Conversation

maxnoe
Copy link
Member

@maxnoe maxnoe commented Mar 10, 2025

Fixes #2428

@maxnoe maxnoe force-pushed the hdf5_high_res_time branch 3 times, most recently from 1bf90b3 to 27718a1 Compare March 10, 2025 15:09
@maxnoe maxnoe force-pushed the hdf5_high_res_time branch from 27718a1 to 5d0eb1a Compare March 10, 2025 15:23
@maxnoe maxnoe requested review from kosack and mdpunch March 10, 2025 15:23
@ctao-dpps-sonarqube CTAO-DPPS-SonarQube

This comment has been minimized.

Sign in to view
@ctao-dpps-sonarqube CTAO-DPPS-SonarQube
Copy link

Passed

Analysis Details

1 Issue

  • Bug 0 Bugs
  • Vulnerability 0 Vulnerabilities
  • Code Smell 1 Code Smell

Coverage and Duplications

  • Coverage 100.00% Coverage (93.70% Estimated after merge)
  • Duplications 0.00% Duplicated Code (0.70% Estimated after merge)

Project ID: cta-observatory_ctapipe_AY52EYhuvuGcMFidNyUs

View in SonarQube

mdpunch
mdpunch approved these changes Mar 11, 2025
View reviewed changes
Copy link

@mdpunch mdpunch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked on running this version on a couple of simtel files, and indeed now instead of having 0ns time-difference between telescopes of an event (due to previous precision loss), I get a couple of tens of ns, as expected.

So, all good for me, thanks!

Tobychev
Tobychev reviewed Mar 17, 2025
View reviewed changes
src/ctapipe/io/tests/test_hdf5.py
for t in times:
writer.write("events", SomeContainer(time=t))

# check that we get a length-3 array when reading back
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this comment accurate? I don't see anything like a length check happening here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tobychev Tobychev Tobychev left review comments

@mdpunch mdpunch mdpunch approved these changes

@kosack kosack Awaiting requested review from kosack

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support writing high-precision timestamps to hdf5
3 participants
@maxnoe @Tobychev @mdpunch