Rename 'classification' field from ReconstructedContainer to 'particle_type' #2763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Draft

Hckjs wants to merge 1 commit into main from naming_particle_class

Contributor

Hckjs commented May 30, 2025 •

edited

Loading

Update DataModel Version to v7.2.0 (DataWriter writes dl2 'particle_type' group instead of 'classification')
HDF5EventSource can read both (morphs 'classification' to 'particle_type')
TableLoader should work as it is (just loops over all nodes children)
particle_type field still reachable via 'classification' but raises DeprecationWarning (can delete it with the next breaking change)

fixes #2759


          Rename 'classification' field from ReconstructedContainer to

'particle_type'

Hckjs marked this pull request as draft

May 30, 2025 16:27

ctao-dpps-sonarqube bot commented May 30, 2025

B Maintainability Rating on New Code (is worse than A)
69.20% Coverage on New Code (is less than 80.00%)

Analysis Details

3 Issues

0 Bugs
0 Vulnerabilities
3 Code Smells

Coverage and Duplications

69.20% Coverage (94.20% Estimated after merge)
0.00% Duplicated Code (0.70% Estimated after merge)

Project ID: cta-observatory_ctapipe_AY52EYhuvuGcMFidNyUs

View in SonarQube

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet