Rework ml model serialization #2773
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxnoe
reviewed
Jun 12, 2025
Co-authored-by: Maximilian Linhoff <[email protected]>
maxnoe
reviewed
Jun 12, 2025
| @@ -386,6 +421,53 @@ def _predict_score(self, key, table): | |||
| def _get_positive_index(self, key): | |||
| return np.nonzero(self._models[key].classes_ == self.positive_class)[0][0] | |||
|
|
|||
| def write(self, path, meta={}, overwrite=False): | |||
| """ | |||
| Save a dictionary using joblib-pickle, which contains all | |||
There was a problem hiding this comment.
This looks like you are implementing your own way of
https://docs.python.org/3/library/pickle.html#object.__getstate__
and
https://docs.python.org/3/library/pickle.html#object.__setstate__
There was a problem hiding this comment.
I started this with the intention of completely removing pickle. I can also convert this to draft until I can finish this.
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
Analysis Details1 Issue
Coverage and Duplications
Project ID: cta-observatory_ctapipe_AY52EYhuvuGcMFidNyUs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a first rework of how we save our ml models. To move away from pickle completely some more changes are still needed, but this fixes #2720 and supersedes #2724.
TODO:
TODO to move away from pickle -> Maybe as a follow up PR: