-
Notifications
You must be signed in to change notification settings - Fork 10
fixed the naming of POINT-LIKE vs FULL-ENCLOSURE IRFs #315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
It is determined depending on the number of bins in camera offset
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #315 +/- ##
=======================================
Coverage 75.79% 75.79%
=======================================
Files 22 22
Lines 2739 2739
=======================================
Hits 2076 2076
Misses 663 663 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…imuth is from the whole run so it will be somewhat different than the value for the first event
|
@Elisa-Visentin for me it is fine to add it if it helps in testing a real case scenario, which is the case. Regarding the approval, I think we need it (probably by both MAGIC and LST since the MC run is a joint one), but just via email to the EBs should be enough. Then I can put it in the webserver with the other test datat. |
|
Hi, don't we have already a diffuse file for the training? We could misuse it for an IRF (in regular analysis of course we would not do it, but for testing the software it is perfectly fine) |
|
We have a couple of diffuse runs for training. I can check if nothing complains when using the same events both for training and for test, and if we need also electrons (it depends on the 'internal checks' of the code) |
|
I just have to check l 209 dl2-dl3 on a test file, just to bbe sure it does what we are expecting it to do, then everythin else is fine |
It is determined depending on the number of bins in camera offset