Skip to content

Conversation

@jsitarek
Copy link
Collaborator

No description provided.

@jsitarek jsitarek marked this pull request as draft December 10, 2025 22:11
@codecov
Copy link

codecov bot commented Dec 10, 2025

Codecov Report

❌ Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 75.75%. Comparing base (fd10d8c) to head (d8d2454).

Files with missing lines Patch % Lines
magicctapipe/io/io.py 0.00% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #318      +/-   ##
==========================================
- Coverage   75.89%   75.75%   -0.14%     
==========================================
  Files          22       22              
  Lines        2750     2755       +5     
==========================================
  Hits         2087     2087              
- Misses        663      668       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jsitarek
Copy link
Collaborator Author

jsitarek commented Dec 12, 2025

alternative method for finding the time delays for broken GPS periods. It is much faster: running on 6 subruns, it took 12 min for the original method and 2 min for this one. For most of the subruns the results are similar

original:
log/coincidence_magic_008_lst_0060.txt-In total 796 stereo events are found:
log/coincidence_magic_008_lst_0060.txt: LST-1_MAGIC-I (type 0): 232 events (29.1%)
log/coincidence_magic_008_lst_0060.txt: LST-1_MAGIC-I_MAGIC-II (type 1): 390 events (49.0%)
log/coincidence_magic_008_lst_0060.txt: LST-1_MAGIC-II (type 2): 64 events (8.0%)
log/coincidence_magic_008_lst_0060.txt: MAGIC-I_MAGIC-II (type 3): 110 events (13.8%)

log/coincidence_magic_009_lst_0060.txt-In total 790 stereo events are found:
log/coincidence_magic_009_lst_0060.txt: LST-1_MAGIC-I (type 0): 14 events (1.8%)
log/coincidence_magic_009_lst_0060.txt: LST-1_MAGIC-I_MAGIC-II (type 1): 363 events (45.9%)
log/coincidence_magic_009_lst_0060.txt: LST-1_MAGIC-II (type 2): 310 events (39.2%)
log/coincidence_magic_009_lst_0060.txt: MAGIC-I_MAGIC-II (type 3): 103 events (13.0%)

log/coincidence_magic_009_lst_0061.txt-In total 1533 stereo events are found:
log/coincidence_magic_009_lst_0061.txt: LST-1_MAGIC-I (type 0): 57 events (3.7%)
log/coincidence_magic_009_lst_0061.txt: LST-1_MAGIC-I_MAGIC-II (type 1): 1005 events (65.6%)
log/coincidence_magic_009_lst_0061.txt: LST-1_MAGIC-II (type 2): 162 events (10.6%)
log/coincidence_magic_009_lst_0061.txt: MAGIC-I_MAGIC-II (type 3): 309 events (20.2%)

log/coincidence_magic_009_lst_0062.txt-In total 1462 stereo events are found:
log/coincidence_magic_009_lst_0062.txt: LST-1_MAGIC-I (type 0): 56 events (3.8%)
log/coincidence_magic_009_lst_0062.txt: LST-1_MAGIC-I_MAGIC-II (type 1): 974 events (66.6%)
log/coincidence_magic_009_lst_0062.txt: LST-1_MAGIC-II (type 2): 137 events (9.4%)
log/coincidence_magic_009_lst_0062.txt: MAGIC-I_MAGIC-II (type 3): 295 events (20.2%)

log/coincidence_magic_009_lst_0063.txt-In total 1584 stereo events are found:
log/coincidence_magic_009_lst_0063.txt: LST-1_MAGIC-I (type 0): 70 events (4.4%)
log/coincidence_magic_009_lst_0063.txt: LST-1_MAGIC-I_MAGIC-II (type 1): 1046 events (66.0%)
log/coincidence_magic_009_lst_0063.txt: LST-1_MAGIC-II (type 2): 167 events (10.5%)
log/coincidence_magic_009_lst_0063.txt: MAGIC-I_MAGIC-II (type 3): 301 events (19.0%)

log/coincidence_magic_009_lst_0064.txt-In total 1526 stereo events are found:
log/coincidence_magic_009_lst_0064.txt: LST-1_MAGIC-I (type 0): 55 events (3.6%)
log/coincidence_magic_009_lst_0064.txt: LST-1_MAGIC-I_MAGIC-II (type 1): 1019 events (66.8%)
log/coincidence_magic_009_lst_0064.txt: LST-1_MAGIC-II (type 2): 161 events (10.6%)
log/coincidence_magic_009_lst_0064.txt: MAGIC-I_MAGIC-II (type 3): 291 events (19.1%)

log/coincidence_magic_009_lst_0065.txt-In total 1505 stereo events are found:
log/coincidence_magic_009_lst_0065.txt: LST-1_MAGIC-I (type 0): 57 events (3.8%)
log/coincidence_magic_009_lst_0065.txt: LST-1_MAGIC-I_MAGIC-II (type 1): 995 events (66.1%)
log/coincidence_magic_009_lst_0065.txt: LST-1_MAGIC-II (type 2): 163 events (10.8%)
log/coincidence_magic_009_lst_0065.txt: MAGIC-I_MAGIC-II (type 3): 290 events (19.3%)

this method:
log/coincidence_magic_008_lst_0060.txt-In total 809 stereo events are found:
log/coincidence_magic_008_lst_0060.txt: LST-1_MAGIC-I (type 0): 243 events (30.0%)
log/coincidence_magic_008_lst_0060.txt: LST-1_MAGIC-I_MAGIC-II (type 1): 392 events (48.5%)
log/coincidence_magic_008_lst_0060.txt: LST-1_MAGIC-II (type 2): 66 events (8.2%)
log/coincidence_magic_008_lst_0060.txt: MAGIC-I_MAGIC-II (type 3): 108 events (13.3%)

log/coincidence_magic_009_lst_0060.txt-In total 790 stereo events are found:
log/coincidence_magic_009_lst_0060.txt: LST-1_MAGIC-I (type 0): 13 events (1.6%)
log/coincidence_magic_009_lst_0060.txt: LST-1_MAGIC-I_MAGIC-II (type 1): 363 events (45.9%)
log/coincidence_magic_009_lst_0060.txt: LST-1_MAGIC-II (type 2): 311 events (39.4%)
log/coincidence_magic_009_lst_0060.txt: MAGIC-I_MAGIC-II (type 3): 103 events (13.0%)

log/coincidence_magic_009_lst_0061.txt-In total 1533 stereo events are found:
log/coincidence_magic_009_lst_0061.txt: LST-1_MAGIC-I (type 0): 57 events (3.7%)
log/coincidence_magic_009_lst_0061.txt: LST-1_MAGIC-I_MAGIC-II (type 1): 1011 events (65.9%)
log/coincidence_magic_009_lst_0061.txt: LST-1_MAGIC-II (type 2): 162 events (10.6%)
log/coincidence_magic_009_lst_0061.txt: MAGIC-I_MAGIC-II (type 3): 303 events (19.8%)

log/coincidence_magic_009_lst_0062.txt-In total 1263 stereo events are found:
log/coincidence_magic_009_lst_0062.txt: LST-1_MAGIC-I (type 0): 172 events (13.6%)
log/coincidence_magic_009_lst_0062.txt: LST-1_MAGIC-I_MAGIC-II (type 1): 726 events (57.5%)
log/coincidence_magic_009_lst_0062.txt: LST-1_MAGIC-II (type 2): 1 events (0.1%)
log/coincidence_magic_009_lst_0062.txt: MAGIC-I_MAGIC-II (type 3): 364 events (28.8%)

log/coincidence_magic_009_lst_0063.txt-In total 1583 stereo events are found:
log/coincidence_magic_009_lst_0063.txt: LST-1_MAGIC-I (type 0): 69 events (4.4%)
log/coincidence_magic_009_lst_0063.txt: LST-1_MAGIC-I_MAGIC-II (type 1): 1046 events (66.1%)
log/coincidence_magic_009_lst_0063.txt: LST-1_MAGIC-II (type 2): 167 events (10.5%)
log/coincidence_magic_009_lst_0063.txt: MAGIC-I_MAGIC-II (type 3): 301 events (19.0%)

log/coincidence_magic_009_lst_0064.txt-In total 1525 stereo events are found:
log/coincidence_magic_009_lst_0064.txt: LST-1_MAGIC-I (type 0): 55 events (3.6%)
log/coincidence_magic_009_lst_0064.txt: LST-1_MAGIC-I_MAGIC-II (type 1): 1018 events (66.8%)
log/coincidence_magic_009_lst_0064.txt: LST-1_MAGIC-II (type 2): 160 events (10.5%)
log/coincidence_magic_009_lst_0064.txt: MAGIC-I_MAGIC-II (type 3): 292 events (19.1%)

log/coincidence_magic_009_lst_0065.txt-In total 1498 stereo events are found:
log/coincidence_magic_009_lst_0065.txt: LST-1_MAGIC-I (type 0): 57 events (3.8%)
log/coincidence_magic_009_lst_0065.txt: LST-1_MAGIC-I_MAGIC-II (type 1): 997 events (66.6%)
log/coincidence_magic_009_lst_0065.txt: LST-1_MAGIC-II (type 2): 156 events (10.4%)
log/coincidence_magic_009_lst_0065.txt: MAGIC-I_MAGIC-II (type 3): 288 events (19.2%)

the first two subruns have no proper time delays computed in neither the original method nor this one. subrun 62 is the only one in which there is significantly less events matched with the new method is also problematic - running only over it the times are not matched properly with neither of the methods

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants