Skip to content

feat(parser): new style parser #681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 21 commits into
base: main
Choose a base branch
from
Open

feat(parser): new style parser #681

wants to merge 21 commits into from

Conversation

tenphi
Copy link
Member

@tenphi tenphi commented May 26, 2025

No description provided.

Copy link

changeset-bot bot commented May 26, 2025

⚠️ No Changeset found

Latest commit: 5f8ef40

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented May 26, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
cube-ui-kit ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 6, 2025 6:59pm

Copy link

netlify bot commented May 26, 2025

Deploy Preview for cube-uikit-docs failed.

Name Link
🔨 Latest commit ae4079a
🔍 Latest deploy log https://app.netlify.com/projects/cube-uikit-docs/deploys/68433a661f6a42000732f636

Copy link
Contributor

github-actions bot commented May 26, 2025

🧪 Storybook is successfully deployed!

Copy link
Contributor

github-actions bot commented May 26, 2025

🏗 Docs are successfully deployed!

👀 Preview: https://68433aaaadac9624188d193e--cube-uikit-docs.netlify.app

Copy link
Contributor

github-actions bot commented May 27, 2025

📦 NPM canary release

Deployed canary version 0.0.0-canary-6b5a4ea.

Copy link
Contributor

github-actions bot commented May 27, 2025

🏋️ Size limit report

Name Size Passed?
All 253.21 KB (+0.37% 🔺) Yes 🎉
Tree shaking (just a Button) 22.36 KB (+3.01% 🔺) Yes 🎉
Tree shaking (just an Icon) 12.05 KB (+5.75% 🔺) Yes 🎉

Click here if you want to find out what is changed in this build

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces a new style parser implementation along with updates to style processing across the codebase. Key changes include refactoring border style parsing to extract properties from processed groups, extending test coverage for various style cases, and enhancing parser and component behavior (including caching and focus management).

Reviewed Changes

Copilot reviewed 43 out of 43 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/tasty/styles/border.ts Refactored borderStyle to extract groups from the parser result using the new "output" property
src/tasty/styles.test.ts Updated expected outputs for border and outline style tests
src/tasty/snapshots/tasty.test.tsx.snap Adjusted snapshot formatting for color functions
src/parser/* Introduced new parser components (tokenizer, LRU cache, classify, documentation, and tests)
src/components/layout/{Suffix,Prefix}.tsx Updated style property extraction to use parser's output
src/components/fields/Slider/* Enhanced slider components with additional QA attributes and improved focus management
.size-limit.cjs Updated bundle size limits
.cursor/rules/* Added new configuration files for tasty and parser rules
Comments suppressed due to low confidence (1)

src/components/fields/Slider/elements.ts:149

  • [nitpick] Ensure that using 'flow' as an alias for 'flexDirection' is a documented and accepted practice in the tasty API to avoid potential confusion.
flow: {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant