refactor(cubesql): Fix manual_strip warning

cube-js · Dec 20, 2024 · 3b57a8d · 3b57a8d
1 parent 520ff2a
commit 3b57a8d
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/rust/cubesql/cubesql/Cargo.toml b/rust/cubesql/cubesql/Cargo.toml
@@ -106,7 +106,6 @@ len_zero = "allow"
 let_and_return = "allow"
 manual_flatten = "allow"
 manual_range_contains = "allow"
-manual_strip = "allow"
 map_clone = "allow"
 map_flatten = "allow"
 map_identity = "allow"

diff --git a/rust/cubesql/cubesql/src/compile/rewrite/rules/filters.rs b/rust/cubesql/cubesql/src/compile/rewrite/rules/filters.rs
@@ -2780,12 +2780,13 @@ impl FilterRules {
                                                     value.to_string()
                                                 }
                                             } else if op == "endsWith" || op == "notEndsWith" {
-                                                if value.starts_with("%") {
-                                                    let without_wildcard = value[1..].to_string();
+                                                if let Some(without_wildcard) =
+                                                    value.strip_prefix("%")
+                                                {
                                                     if without_wildcard.contains("%") {
                                                         continue;
                                                     }
-                                                    without_wildcard
+                                                    without_wildcard.to_string()
                                                 } else {
                                                     value.to_string()
                                                 }