Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cubesql): Add forgotten Distinct in ast_size_outside_wrapper cost component #8882

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mcheshkov
Copy link
Member

Check List

  • Tests has been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

Copy link

vercel bot commented Oct 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

8 Skipped Deployments
Name Status Preview Comments Updated (UTC)
examples-angular-dashboard ⬜️ Ignored (Inspect) Visit Preview Nov 27, 2024 0:55am
examples-react-d3 ⬜️ Ignored (Inspect) Visit Preview Nov 27, 2024 0:55am
examples-react-dashboard ⬜️ Ignored (Inspect) Visit Preview Nov 27, 2024 0:55am
examples-react-data-table ⬜️ Ignored (Inspect) Visit Preview Nov 27, 2024 0:55am
examples-react-highcharts ⬜️ Ignored (Inspect) Visit Preview Nov 27, 2024 0:55am
examples-react-material-ui ⬜️ Ignored (Inspect) Visit Preview Nov 27, 2024 0:55am
examples-react-pivot-table ⬜️ Ignored (Inspect) Visit Preview Nov 27, 2024 0:55am
examples-vue-query-builder ⬜️ Ignored (Inspect) Visit Preview Nov 27, 2024 0:55am

Copy link

codecov bot commented Oct 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.85%. Comparing base (10e47fc) to head (09697b0).
Report is 4 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8882   +/-   ##
=======================================
  Coverage   82.85%   82.85%           
=======================================
  Files         221      221           
  Lines       78813    78814    +1     
=======================================
+ Hits        65300    65301    +1     
  Misses      13513    13513           
Flag Coverage Δ
cubesql 82.85% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mcheshkov mcheshkov marked this pull request as ready for review October 30, 2024 01:13
@mcheshkov mcheshkov requested a review from a team as a code owner October 30, 2024 01:13
@mcheshkov mcheshkov force-pushed the forgotten-distinct-cost branch from ef9d11e to 2710fe3 Compare November 13, 2024 11:57
@mcheshkov mcheshkov force-pushed the forgotten-distinct-cost branch from 2710fe3 to 711a2f2 Compare November 27, 2024 12:54
@mcheshkov mcheshkov force-pushed the forgotten-distinct-cost branch from 711a2f2 to 09697b0 Compare December 20, 2024 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant