Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cubesql): Calculate proper limit and offset for CubeScan in nested limits case #8924

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mcheshkov
Copy link
Member

Check List

  • Tests has been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

Description of Changes Made (if issue reference is not provided)

Before this in Limit(Limit(CubeScan)) logical plan outer fetch and skip values would win.
Not they are calculated properly.

Copy link

codecov bot commented Nov 7, 2024

Codecov Report

Attention: Patch coverage is 99.44134% with 2 lines in your changes missing coverage. Please review.

Project coverage is 82.92%. Comparing base (10e47fc) to head (84660d1).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
...besql/cubesql/src/compile/rewrite/rules/members.rs 96.42% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8924      +/-   ##
==========================================
+ Coverage   82.85%   82.92%   +0.06%     
==========================================
  Files         221      222       +1     
  Lines       78813    79144     +331     
==========================================
+ Hits        65300    65628     +328     
- Misses      13513    13516       +3     
Flag Coverage Δ
cubesql 82.92% <99.44%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

vercel bot commented Nov 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

8 Skipped Deployments
Name Status Preview Comments Updated (UTC)
examples-angular-dashboard ⬜️ Ignored (Inspect) Visit Preview Nov 13, 2024 0:09am
examples-react-d3 ⬜️ Ignored (Inspect) Visit Preview Nov 13, 2024 0:09am
examples-react-dashboard ⬜️ Ignored (Inspect) Visit Preview Nov 13, 2024 0:09am
examples-react-data-table ⬜️ Ignored (Inspect) Visit Preview Nov 13, 2024 0:09am
examples-react-highcharts ⬜️ Ignored (Inspect) Visit Preview Nov 13, 2024 0:09am
examples-react-material-ui ⬜️ Ignored (Inspect) Visit Preview Nov 13, 2024 0:09am
examples-react-pivot-table ⬜️ Ignored (Inspect) Visit Preview Nov 13, 2024 0:09am
examples-vue-query-builder ⬜️ Ignored (Inspect) Visit Preview Nov 13, 2024 0:09am

@mcheshkov mcheshkov force-pushed the push-cubescan-limit-calc branch 5 times, most recently from 80ea85b to f926c8c Compare November 13, 2024 12:09
@mcheshkov mcheshkov force-pushed the push-cubescan-limit-calc branch from f926c8c to 4e244c9 Compare December 6, 2024 18:32
@mcheshkov mcheshkov marked this pull request as ready for review December 6, 2024 19:13
@mcheshkov mcheshkov requested a review from a team as a code owner December 6, 2024 19:13
@mcheshkov mcheshkov force-pushed the push-cubescan-limit-calc branch from 4e244c9 to 84660d1 Compare December 20, 2024 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant