chore(cubesql): E2E - check that env variables are not empty #8965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8965 +/- ##
==========================================
- Coverage 82.66% 82.65% -0.01%
==========================================
Files 221 221
Lines 78303 78303
==========================================
- Hits 64726 64722 -4
- Misses 13577 13581 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
ptiurin
pushed a commit
to firebolt-db/cube
that referenced
this pull request
Nov 27, 2024
…#8965) I figured out that CI is broken for contributors. I am not sure, but I believe it's related to the fact that environment variables are defined while being empty due to security restrictions for CI's variables.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I figured out that CI is broken for contributors. I am not totally sure, but I belive it's related to that env variables are defined, while being empty.
#8947