fix(backend-native): Pass req.securityContext to Python config #9049
+49
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #9049 +/- ##
=======================================
Coverage 82.85% 82.85%
=======================================
Files 221 221
Lines 78813 78813
=======================================
Hits 65300 65300
Misses 13513 13513
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
mcheshkov
force-pushed
the
py-extend-context
branch
from
b2fa49c to
32e754f
Compare
KSDaemon
reviewed
Dec 16, 2024
ovr
approved these changes
Dec 16, 2024
mcheshkov
force-pushed
the
py-extend-context
branch
from
32e754f to
44beed0
Compare
This is necessary for `extend_context`. By the time `extendContext` is called, `req` in JS-land is already extended with `securityContext` after `checkAuth`, and JS config receives it with extensions.
mcheshkov
force-pushed
the
py-extend-context
branch
from
44beed0 to
3582c60
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is necessary for
extend_context. By the timeextendContextis called,reqin JS-land is already extended withsecurityContextaftercheckAuth, and JS config receives it with extensions.Check List
Issue Reference this PR resolves
#8753
Description of Changes Made (if issue reference is not provided)
This is necessary for
extend_context. By the timeextendContextis called,reqin JS-land is already extended withsecurityContextaftercheckAuth, and JS config receives it with extensions.