Conversation
Github automatically converts headers in Markdown to HTML links. Unfortunately this includes any emoji included in the header. So is linked to as `https://github.com/cucumber#get-in-touch-%EF%B8%8F` which is hard to parse and easy to break should the the emoji change.
mpkorstanje
force-pushed
the
mpkorstanje-patch-2
branch
from
a8afb06 to
ca70963
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Github automatically converts headers in Markdown to HTML links.
Unfortunately this includes any emoji included in the header. So
is linked to as
https://github.com/cucumber#get-in-touch-%EF%B8%8Fwhich is hard to parse and easy to break should the the emoji change.Removing the emoji will make cucumber/common#2195 a bit easier, but also remove some color.