Skip to content

Commit

Permalink
[.NET] Reduce NuGet size by only targeting .NET Standard 2.0 (#363)
Browse files Browse the repository at this point in the history
  • Loading branch information
obligaron authored Feb 5, 2025
1 parent 1cacfe7 commit 5b54a36
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 4 deletions.
3 changes: 1 addition & 2 deletions .github/workflows/test-dotnet.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,7 @@ on:

jobs:
test-dotnet:
# Failing on `ubuntu-24.04` (https://github.com/cucumber/gherkin/issues/349)
runs-on: ubuntu-22.04
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: actions/setup-dotnet@v4
Expand Down
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,9 @@ This document is formatted according to the principles of [Keep A CHANGELOG](htt

## [Unreleased]

### Changed
- [.NET] Reduce NuGet size by only targeting .NET Standard 2.0

### Fixed
- [.NET] Fix NuGet package generation

Expand Down
3 changes: 2 additions & 1 deletion dotnet/Gherkin.Specs/Gherkin.Specs.csproj
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFrameworks>net9.0;net8.0;net472</TargetFrameworks>
<TargetFrameworks>net9.0;net8.0</TargetFrameworks>
<TargetFrameworks Condition="$([MSBuild]::IsOSPlatform('windows'))">$(TargetFrameworks);net472</TargetFrameworks>
<OutputType>Exe</OutputType>
<StartupObject>Gherkin.Specs.CLI.Program</StartupObject>
</PropertyGroup>
Expand Down
2 changes: 1 addition & 1 deletion dotnet/Gherkin/Gherkin.csproj
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFrameworks>net8.0;netstandard2.0</TargetFrameworks>
<TargetFrameworks>netstandard2.0</TargetFrameworks>
<GenerateDocumentationFile>true</GenerateDocumentationFile>
<NoWarn>1591</NoWarn>
<Deterministic Condition="'$(Configuration)' == 'Release'">false</Deterministic>
Expand Down

0 comments on commit 5b54a36

Please sign in to comment.