Skip to content

Replace deprecated ::set-output #292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 28, 2025
Merged

Conversation

nodeg
Copy link
Member

@nodeg nodeg commented Mar 14, 2025

🤔 What's changed?

As per the deprecation warning and explanation at https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

⚡️ What's your motivation?

See cucumber/common#2150

🏷️ What kind of change is this?

  • 🏦 Refactoring/debt/DX (improvement to code design, tooling, etc. without changing behaviour)

♻️ Anything particular you want feedback on?

Is the changelog entry fine this way?

📋 Checklist:


This text was originally generated from a template, then edited by hand. You can modify the template here.

@codecov-commenter
Copy link

codecov-commenter commented Mar 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (c7f86ad) to head (69f429f).
Report is 10 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #292   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            3         3           
  Lines          200       200           
=========================================
  Hits           200       200           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nodeg nodeg self-assigned this Mar 14, 2025
Copy link
Contributor

@mpkorstanje mpkorstanje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cheers, but no changelog needed. No need for users to know this.

@nodeg
Copy link
Member Author

nodeg commented Mar 22, 2025

Please squash the commits before merging. I additionally did a rebase.

@nodeg nodeg requested a review from mpkorstanje March 22, 2025 16:32
@mpkorstanje mpkorstanje merged commit 79ea0c7 into cucumber:main Mar 28, 2025
38 checks passed
@nodeg nodeg deleted the ci_set_output branch March 28, 2025 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants