Skip to content

Hugo: breaking shortcodes in shortcodes #458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

anne-usmedia
Copy link
Collaborator

Add spaceless ('-') to statements and variables so the "markdownify" doesn't break the html code.
In the tabs.html the indent had to be undone for it to work.

For cue-lang/cue#3005 and cue-lang/cue#3002

Add spaceless ('-') to statements and variables so
the "markdownify" doesn't break the html code.
In the tabs.html the indent had to be undone for it to work.

For cue-lang/cue#3005 and cue-lang/cue#3002

Signed-off-by: Anne van Gorkom <[email protected]>
Copy link

netlify bot commented Jun 3, 2024

Deploy Preview for cue ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 81ea7d1
🔍 Latest deploy log https://app.netlify.com/sites/cue/deploys/665d75ab8f4ec700082af794
😎 Deploy Preview https://deploy-preview-458--cue.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@myitcv
Copy link
Member

myitcv commented Jun 3, 2024

Taking a look at this now.

cueckoo pushed a commit that referenced this pull request Jun 3, 2024
Add spaceless ('-') to statements and variables so
the "markdownify" doesn't break the html code.
In the tabs.html the indent had to be undone for it to work.

For cue-lang/cue#3005 and cue-lang/cue#3002

Closes #458 as merged as of commit 81ea7d1.

Signed-off-by: Anne van Gorkom <[email protected]>
Change-Id: Ie155afabd8f537a0cfa3143d974f1c198998bd2d
@myitcv
Copy link
Member

myitcv commented Jun 3, 2024

I've imported this as https://review.gerrithub.io/c/cue-lang/cuelang.org/+/1195633 and rebased the changes in https://review.gerrithub.io/c/cue-lang/cuelang.org/+/1191217 on top to see the result. Appears to be working well, thank you.

@anne-usmedia @JorindeUsMedia I can also share details on how to get the PR trybot workflows working in your fork.

@myitcv myitcv marked this pull request as ready for review June 3, 2024 12:44
@myitcv myitcv requested a review from cueckoo as a code owner June 3, 2024 12:44
Copy link
Member

@myitcv myitcv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Imported and tested via Gerrit.

@cueckoo cueckoo closed this in 6fdf292 Jun 3, 2024
@anne-usmedia anne-usmedia deleted the feature/CUE-3-code-tabs-in-step branch June 3, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants