Skip to content

hugo: remove indenting tabs so they do not break #459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

anne-usmedia
Copy link
Collaborator

@anne-usmedia anne-usmedia commented Jun 4, 2024

  • removed breaking indenting from tabs
  • added more spaceless characters

For testing, add the example code from the issue
below to a test page. Check if you see 2 tabs in
the code block.

For cue-lang/cue#3192

Copy link

netlify bot commented Jun 4, 2024

Deploy Preview for cue ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit a9ff5a9
🔍 Latest deploy log https://app.netlify.com/sites/cue/deploys/665f0871e9b50e0008b575dd
😎 Deploy Preview https://deploy-preview-459--cue.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

- removed breaking indenting from tabs
- added more spaceless characters

For testing, add the example code from the issue
below to a test page. Check if you see 2 tabs in
the code block.

For cue-lang/cue#3192

Signed-off-by: Anne van Gorkom <[email protected]>
@anne-usmedia anne-usmedia force-pushed the feature/cue-multiple-tabs-in-code-tabs-in-steps branch from c683124 to a9ff5a9 Compare June 4, 2024 12:28
@anne-usmedia anne-usmedia marked this pull request as ready for review June 4, 2024 12:36
@anne-usmedia anne-usmedia requested a review from cueckoo as a code owner June 4, 2024 12:36
@jpluscplusm
Copy link
Collaborator

This fixes the example in cue-lang/cue#3192 for me, as well as an expanded example with several more files. Passing to @myitcv in case there are more test cases available.

@jpluscplusm jpluscplusm requested a review from myitcv June 4, 2024 12:49
Copy link
Member

@myitcv myitcv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Will import into Gerrit now.

cueckoo pushed a commit that referenced this pull request Jun 4, 2024
- removed breaking indenting from tabs
- added more spaceless characters

For testing, add the example code from the issue
below to a test page. Check if you see 2 tabs in
the code block.

For cue-lang/cue#3192

Closes #459 as merged as of commit a9ff5a9.

Signed-off-by: Anne van Gorkom <[email protected]>
Change-Id: I79300c648acf75592df2ce4f308c8e7d428d5d68
@cueckoo cueckoo closed this in 767d558 Jun 4, 2024
@anne-usmedia anne-usmedia deleted the feature/cue-multiple-tabs-in-code-tabs-in-steps branch June 4, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants