hugo: Allow preselected tags on search #477
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ Deploy Preview for cue failed.Built without sensitive environment variables
|
Wies-UsMedia
force-pushed
the
feature/3394
branch
from
4d81a5f
to
fcca273
Compare
Wies-UsMedia
requested review from
JorindeUsMedia,
JuanUsMedia,
jpluscplusm and
anne-usmedia
JorindeUsMedia
approved these changes
Nov 1, 2024
JorindeUsMedia
suggested changes
Nov 5, 2024
Adds a feature to allow tags to added to the search widget. These will be preselected tags, but can be manually removed after by the user. To test and compare, see: https://cuelang.org/examples/shortcodes/search/ Fixes cue-lang/cue#3394 Signed-off-by: Wies de Graaf <[email protected]>
Wies-UsMedia
force-pushed
the
feature/3394
branch
from
fcca273
to
3963a41
Compare
|
@Wies-UsMedia Is this ready for (re-)review? |
It is yep! |
|
CI passed. Preview is here: https://cl-1203609-1--cue-cls.netlify.app/ |
jpluscplusm
approved these changes
Nov 5, 2024
There was a problem hiding this comment.
Reviewed via https://cl-1203609-1--cue-cls.netlify.app/examples/shortcodes/search/.
We still have a corner-corner case where removing the last tag leaves an empty q query string param, but then resets the tags to the predefined set, but that's sufficiently niche that I'll just track it as a new issue that we can address if it becomes a problem. Edit: tracked as cue-lang/cue#3556
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commit message.
To test, go to https://deploy-preview-477--cue.netlify.app/examples/shortcodes/search/ and you should be able to add new tags, as well as remove the preselected tags.