Skip to content

Database environment variable fixes for Debezium Server #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 14, 2024
Merged

Database environment variable fixes for Debezium Server #53

merged 2 commits into from
Oct 14, 2024

Conversation

m-dwyer
Copy link
Contributor

@m-dwyer m-dwyer commented Oct 11, 2024

Context

There are a couple of fixes / changes to apply for the Debezium Server DevBox plugin surrounding environment variable usage

Changes

  • The database host should be DB_HOSTNAME in the populate script, not DB_HOST
  • We default the DB_PORT to PGPORT where it exists with 5432 (the postgres default) as a fallback. Some teams were overriding PGPORT and were not also updating DB_PORT at the same time, which was confusing

@m-dwyer m-dwyer marked this pull request as ready for review October 14, 2024 00:29
@t-monaghan t-monaghan merged commit c2ae234 into main Oct 14, 2024
5 checks passed
@t-monaghan t-monaghan deleted the db-env-var-fixes branch October 14, 2024 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t-monaghan t-monaghan t-monaghan approved these changes

@cultureamp-brucew cultureamp-brucew Awaiting requested review from cultureamp-brucew

@burritobill burritobill Awaiting requested review from burritobill

@jasononeil jasononeil Awaiting requested review from jasononeil

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@m-dwyer @t-monaghan