-
Notifications
You must be signed in to change notification settings - Fork 0
introduces ca-changesets plugin #55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work. Especially the extra thinking around checking if the nodejs version would be clobbered. And working out how to get it installed without the node_modules folder.
I tested on ca-hellowworld-ruby by adding:
"include": [
"github:cultureamp/devbox-extras/tfm/changeset-thin-fef-1768/?dir=plugins/ca-changesets"
],
It looks like changeset
wasn't appearing on my path so I couldn't call it with just changeset
I was able to call it directly with:
.devbox/virtenv/cultureamp.devbox-extras.ca-changesets/bin/changeset
and verified that that works.
I've fixed the issue with changeset not appearing on path. It's due to a bug in devbox not being able to manipulate an environment variable twice. See: jetify-com/devbox#2138 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice. Have tested against ca-helloworld-ruby and this works so I think you can merge.
(It didn't seem to work first go. I tried deleting .devbox and it still didn't seem to work. after a devbox update
it worked though. THere's no mention of the plugin in devbox.lock so I'm not sure how that works.)
A thin wrapper to @changesets/cli, using the
npx
command to callchangeset
.This will install
changeset
if it does not already exist, without requirement of apackage.json
file, and without creating anode_modules/
directory.I have ensured that: