Skip to content

feat: allow external postgres to be used by debezium plugin #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 21, 2024

Conversation

davidlopezre
Copy link
Contributor

@davidlopezre davidlopezre commented Nov 20, 2024

This PR changes the readiness command to allow the Debezium server plugin to use a postgres outside of the devbox virtual environment.

@jay-aye-see-kay
Copy link
Contributor

The change seems reasonable, just wanted to understand the naming of env vars in that plugin.

The common pattern I’ve seen in the past is setting PGHOST PGPORT PGUSER etc for the project and all cli tools will pick up on those without having to set flags.

But in this plugin we use DB_* env vars which don’t get picked up automatically (by anything know of). Is this intentional to prevent conflicts outside the plugin?

@m-dwyer
Copy link
Contributor

m-dwyer commented Nov 20, 2024

The change seems reasonable, just wanted to understand the naming of env vars in that plugin.

The common pattern I’ve seen in the past is setting PGHOST PGPORT PGUSER etc for the project and all cli tools will pick up on those without having to set flags.

But in this plugin we use DB_* env vars which don’t get picked up automatically (by anything know of). Is this intentional to prevent conflicts outside the plugin?

Good call out.

The reason we settled on DB_* is because we envisage the possibility of extending the debezium server plugin.

At the moment, it just contains a static config file that uses the PostgresConnector and implements the Outbox pattern, but there may be a point where we extend out the functionality to Mongo or another DBMS, allowing us to have a consistent way for implementing local CDC across different databases.

@davidlopezre davidlopezre merged commit 68b5f0d into main Nov 21, 2024
5 checks passed
@davidlopezre davidlopezre deleted the dl/allow-external-postgres-debezium branch November 21, 2024 04:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants