Skip to content

Conversation

@cmeister2
Copy link
Collaborator

@cmeister2 cmeister2 commented Mar 8, 2025

  • Move Python files into tooling directory and create PyProject configuration
  • Add typing and docstrings to all classes
  • Use ruff for linting and formatting
  • Add docs

Copy link

@dfandrich dfandrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any thing here that requires poetry, which adds a ton of dependencies. I'd just use the lowest common denominator setuptools instead.

@cmeister2
Copy link
Collaborator Author

cmeister2 commented Mar 8, 2025

I don't see any thing here that requires poetry, which adds a ton of dependencies. I'd just use the lowest common denominator setuptools instead.

I have a mild preference for Poetry given that I use it a lot (and as previously mentioned, am likely to be the primary/sole user of these scripts) but I can look into stock pyproject.tomls if you feel strongly.

EDIT: it looks like with v2 of Poetry it's compatible with pip install ., so maybe this is entirely moot.

$ pip install .
Processing HOME/code/github/curl/curl-fuzzer
  Installing build dependencies ... done
  Getting requirements to build wheel ... done
    Preparing wheel metadata ... done
Collecting scapy<3.0.0,>=2.6.1
  Downloading scapy-2.6.1-py3-none-any.whl (2.4 MB)
     |████████████████████████████████| 2.4 MB 2.8 MB/s 
Building wheels for collected packages: curl-fuzzer-tools
  Building wheel for curl-fuzzer-tools (PEP 517) ... done
  Created wheel for curl-fuzzer-tools: filename=curl_fuzzer_tools-0.1.0-py3-none-any.whl size=14292 sha256=611e4170e7bd0533fc2f290855b6623654103ef7ef931a941c848f043d885887
  Stored in directory: HOME/.cache/pip/wheels/e0/61/aa/29ecb12123a532056085b3ca8687f41911604951f89ec1d93d
Successfully built curl-fuzzer-tools
Installing collected packages: scapy, curl-fuzzer-tools
Successfully installed curl-fuzzer-tools-0.1.0 scapy-2.6.1

@cmeister2 cmeister2 changed the title WIP: Python updates Python updates Mar 9, 2025
@cmeister2 cmeister2 merged commit 2c82bb3 into master Mar 9, 2025
18 checks passed
@cmeister2 cmeister2 deleted the cm2/poetry branch March 9, 2025 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants