introduce 'excludes' option for tests #395
Open
+132
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure why the curl for win is failing. Will investigate tomorrow |
|
The curl-for-win build is failing on my clone of trurl on master, which was synced this morning: https://github.com/jacobmealey/urler/actions/runs/16097961365/job/45423345923 The daily builds on the curl-for-win repo are passing. cc @vszakats |
vszakats
added a commit
to curl/curl-for-win
that referenced
this pull request
Jul 6, 2025
Static libcurl on Windows, built for Vista and up requires the iphlpapi system DLL since this curl commit: curl/curl@0d71b18 curl/curl#17413 Reported-by: Jacob Mealey Bug: curl/trurl#395 (comment)
|
@jacobmealey Thanks for reporting this. Indeed, static libcurl needs linking Is it better after this?: (it's enough to retry the CI job or push any change to trigger a fresh run) |
|
@vszakats that worked! Thank you! |
bagder
requested changes
Jul 15, 2025
…om libcurl Thanks @charles2910 for reporting this bug fixes: curl#394
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses hexadecimal changes from curl 8.15. I've also duplicated the tests that were failing with the new uppercase hex values.
Thanks @charles2910 for reporting this bug
fixes: #394