Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate css and scss to Tree sitter queries #2853

Open
wants to merge 16 commits into
base: main
Choose a base branch
from

Conversation

AndreasArvidsson
Copy link
Member

No description provided.

@AndreasArvidsson AndreasArvidsson requested a review from a team as a code owner February 12, 2025 16:05
@AndreasArvidsson AndreasArvidsson changed the title Css migration to scm Migrate css and scss to Tree sitter queries Feb 12, 2025
Copy link
Member

@pokey pokey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good but would love to avoid adding that new predicate. feels a bit special esp the notText thing

Comment on lines +74 to +75
(_) @argumentOrParameter
(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how come you can't do something like the following instead of adding the new grow-to-named-siblings! predicate?

Suggested change
(_) @argumentOrParameter
(
(_) @argumentOrParameter.start
(_)? @argumentOrParameter.end
(#not-eq? argumentOrParameter.end "at")
.
(

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could never get something like that to work. Your example here doesn't work either. I would happily accept a solution like this that works, but I couldn't find it on my own.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants