-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: user profile #589
Merged
Merged
feat: user profile #589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
c7c652f
to
c17ec05
Compare
0xtutti
previously approved these changes
Jan 8, 2025
DanielSchiavini
approved these changes
Jan 15, 2025
packages/curve-ui-kit/src/features/connect-wallet/ui/ConnectedWalletLabel.tsx
Show resolved
Hide resolved
packages/curve-ui-kit/src/features/user-profile/settings/advanced-mode/AdvancedMode.tsx
Show resolved
Hide resolved
OnlyJousting
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is not even close to being finished, but because I'm touching global settings and stores that are all over place in the apps, I want to keep it small and not keep the PR open too long.
switch-theme
andswitch-advanced-mode
toggles. They differ enough that I couldn't re-use them in the user profile. I'm not sure if we want to keep those components as generic 'features', rather than just part of the component that hosts them.useUserProfileStore()
.global
value. This used to be calledrouter
but was used globally anyway in all four different apps, hence the rename. Any other 'property' is usually a slippage setting for a certain pool & chain id combination.app
orglobal
Zustand slices. Hence the reason this PR is so big: the entire app now needs to use the new store.