Semesters resource and ability to follow API links #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 10 commits
March 1, 2015 16:49
|
VCR is required for testing, there should be a better way to resolve the dependency issues. |
added 2 commits
March 4, 2015 18:24
…ty to map wrapped array in api response
|
IMHO the fault is on vcr's side. The fix was merged to master in October 2014, but no tagged version was released since September 2014. I've found a workaround in moving the vcr from kosapi_client.gemspec to Gemfile and use master branch (maybe lock commit sha) as At this time I don't se any other way. |
|
I'll close this merge request and issue a new one with proper branch separation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement semesters resource (#7) and ability to follow all API links in response (#3).
VCR gem was removed, because of requirement of faraday >=0.9 of some gems. To me it seems reasonable, because of vcr being only development dependency.