Revert paramio changes #827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So, although paramio lets us query the parameter file "fully" now in CIAO 4.16, we
a) had some complexity added to hide stderr output
b) we couldn't get the min/max limits before applying any re-directs
The limit handling could maybe be reworked, as the current implementation is "interesting", but it's too late to fix for 4.16 and it still wouldn't address the fact that we can't get the actual limit rather than the re-directed value. So revert these changes.
Note that the runtool module is now left in an "interesting" state, as it goes back to the version before #815 was merged. As mentioned by @kglotfelty in #816 it's not easy to re-create the file at the moment thanks to unwanted files in the parameter directories.