Skip to content

Conversation

@erikgb
Copy link
Collaborator

@erikgb erikgb commented Aug 9, 2025

While debugging some failed tests, I noticed that we use a deprecated Ginkgo option. This PR fixes it with what I think would be equivalent functionality.

Warning when running tests:

--ginkgo.progress is deprecated .  The functionality provided by --progress was confusing and is no longer needed.  Use --show-node-events instead to see node entry and exit events included in the timeline of failed and verbose specs.  Or you can run with -vv to always see all node events.  Lastly, --poll-progress-after and the PollProgressAfter decorator now provide a better mechanism for debugging specs that tend to get stuck

Copy link
Member

@zoetrope zoetrope left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@zoetrope zoetrope merged commit af7d797 into cybozu-go:main Aug 12, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants