Update recipe page to reflect new oneOrMore requirement#451
Open
dean-krueger wants to merge 3 commits intocyclus:sourcefrom
Open
Update recipe page to reflect new oneOrMore requirement#451dean-krueger wants to merge 3 commits intocyclus:sourcefrom
dean-krueger wants to merge 3 commits intocyclus:sourcefrom
Conversation
gonuke
requested changes
Mar 5, 2026
Member
gonuke
left a comment
gonuke
left a comment
There was a problem hiding this comment.
Just one little question about the change to ignore
| source/user/CYCAMORE_INSTALL.rst | ||
| source/user/DEPENDENCIES.rst | ||
| source/user/CYCAMORE_DEPS.rst | ||
| source/kernel/core |
Member
There was a problem hiding this comment.
what is this ignore about? Should we just ignore all instances of core?
Contributor
Author
There was a problem hiding this comment.
I am honestly not sure, I just saw it in my folder and it seemed like the kind of file that gets generated by VS code or something and figured it should be on the list. I can change it to try to ignore everything involving core if that's better.
Member
There was a problem hiding this comment.
Usually core represents some file that is generated during a segfault. I agree we should ignore them, but it might make sense to just ignore core files wherever they exist
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Updates the recipe page of fuelcycle.org to reflect new oneOrMore requirement. Descriptions of the recipe block as "Optional" were changed to "Required".
Design Notes
None.
Check the box if your change does not break any of the following:
Related CEPs and Issues
Fixes #450
Associated Developers
None
Testing and Validation
Reviewers, please refer to the Cyclus Guide for Reviewers.