-
Notifications
You must be signed in to change notification settings - Fork 891
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show unique views on advanced stats page #376
base: master
Are you sure you want to change the base?
Conversation
@@ -55,7 +55,7 @@ | |||
|
|||
<div class="row bottom-padding"> | |||
<div class="col-md-8"> | |||
<h4>Traffic over Time</h4> (total: {{ $link->clicks }}) | |||
<h4>Traffic over Time</h4> (total: {{ $link->clicks }}) (unique: {{ $uniques }}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Placing the "unique" number of clicks next to the "total" number of clicks is a bit deceiving. The uniques count is calculated using the base rows from our existing stats, which only fetches rows from the given time period, whereas the "total" number is a count that encompasses all time clicks. If this is the behaviour we want, we should clarify this point, or move the count somewhere else.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've updated it to not take into account the date range.
I changed it to just show the total unique views of all time, but I think it's a bit confusing since it says "Traffic Over Time" right with the total number, right above a graph that only shows your selected date range. |
Are you happy with that change? |
As per #346 I have added a unique hit counter to the title above the chart.