Add basic OpenID Connect support #533
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_LOGIN_CAPTION env to allow customisation of login button text
amex-doug
reviewed
Mar 31, 2021
| return redirect()->route('index'); | ||
| } | ||
|
|
||
| public function performOpenIDConnect(Request $request) { |
There was a problem hiding this comment.
@Jamie0 I would suggest a more agnostic approach here. For example, I would add a factory and strategy pattern here to determine the authentication system based on the configuration.
I would suggest adding an additional env var to determine which Authentication system to use. Ex, default, openid, oauth2.0. This way, you can check which authentication system is configured and then instantiate the respective strategy for authenticating.
|
Is this still active? @Jamie0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds bare bones OAuth 2.0 support by implementing an OpenID Connect client.
To authenticate via OpenID, navigate to
/login/openid. This PR also provides an option to always use OpenID (overridable by navigating to/login/internal), which enterprise users may find useful.The extension can be configured with the following environmental variables:
Resolves #495