Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Snapshot updates for rcc-smoke (null) #2165

Merged
merged 1 commit into from
Dec 22, 2023
Merged

Snapshot updates for rcc-smoke (null) #2165

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 10 additions & 13 deletions tests/testthat/_snaps/filter-dm.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
Condition
Warning:
The `table` argument of `dm_filter()` is deprecated as of dm 1.0.0.
`dm_filter()` now takes named filter expressions, the names correspond to the tables to be filtered. You no longer need to call `dm_apply_filters()` to materialize the filters.
i `dm_filter()` now takes named filter expressions, the names correspond to the tables to be filtered. You no longer need to call `dm_apply_filters()` to materialize the filters.
Output
-- Metadata --------------------------------------------------------------------
Tables: `tf_1`, `tf_2`, `tf_3`, `tf_4`, `tf_5`, `tf_6`
Expand All @@ -19,10 +19,10 @@
Condition
Warning:
The `dm` argument of `dm_filter()` is deprecated as of dm 1.0.0.
Please use the `.dm` argument instead.
i Please use the `.dm` argument instead.
Warning:
The `table` argument of `dm_filter()` is deprecated as of dm 1.0.0.
`dm_filter()` now takes named filter expressions, the names correspond to the tables to be filtered. You no longer need to call `dm_apply_filters()` to materialize the filters.
i `dm_filter()` now takes named filter expressions, the names correspond to the tables to be filtered. You no longer need to call `dm_apply_filters()` to materialize the filters.
Output
-- Metadata --------------------------------------------------------------------
Tables: `tf_1`, `tf_2`, `tf_3`, `tf_4`, `tf_5`, `tf_6`
Expand All @@ -36,7 +36,7 @@
Condition
Warning:
The `table` argument of `dm_filter()` is deprecated as of dm 1.0.0.
`dm_filter()` now takes named filter expressions, the names correspond to the tables to be filtered. You no longer need to call `dm_apply_filters()` to materialize the filters.
i `dm_filter()` now takes named filter expressions, the names correspond to the tables to be filtered. You no longer need to call `dm_apply_filters()` to materialize the filters.
Output
-- Metadata --------------------------------------------------------------------
Tables: `tf_1`, `tf_2`, `tf_3`, `tf_4`, `tf_5`, `tf_6`
Expand All @@ -48,7 +48,7 @@
Condition
Warning:
`dm_apply_filters()` was deprecated in dm 1.0.0.
Calling `dm_apply_filters()` after `dm_filter()` is no longer necessary.
i Calling `dm_apply_filters()` after `dm_filter()` is no longer necessary.
Output
-- Metadata --------------------------------------------------------------------
Tables: `tf_1`, `tf_2`, `tf_3`, `tf_4`, `tf_5`, `tf_6`
Expand All @@ -60,7 +60,7 @@
Condition
Warning:
The `table` argument of `dm_filter()` is deprecated as of dm 1.0.0.
`dm_filter()` now takes named filter expressions, the names correspond to the tables to be filtered. You no longer need to call `dm_apply_filters()` to materialize the filters.
i `dm_filter()` now takes named filter expressions, the names correspond to the tables to be filtered. You no longer need to call `dm_apply_filters()` to materialize the filters.
Output
# A tibble: 3 x 4
c d e e1
Expand All @@ -73,7 +73,7 @@
Condition
Warning:
`dm_apply_filters_to_tbl()` was deprecated in dm 1.0.0.
Access tables directly after `dm_filter()`.
i Access tables directly after `dm_filter()`.
Output
# A tibble: 3 x 4
c d e e1
Expand All @@ -86,7 +86,7 @@
Condition
Warning:
The `table` argument of `dm_filter()` is deprecated as of dm 1.0.0.
`dm_filter()` now takes named filter expressions, the names correspond to the tables to be filtered. You no longer need to call `dm_apply_filters()` to materialize the filters.
i `dm_filter()` now takes named filter expressions, the names correspond to the tables to be filtered. You no longer need to call `dm_apply_filters()` to materialize the filters.
Output
# A tibble: 1 x 3
table filter zoomed
Expand All @@ -97,10 +97,10 @@
Condition
Warning:
`dm_get_filters()` was deprecated in dm 1.0.0.
Filter conditions are no longer stored with the dm object.
i Filter conditions are no longer stored with the dm object.
Output
# A tibble: 0 x 3
# ... with 3 variables: table <chr>, filter <list>, zoomed <lgl>
# i 3 variables: table <chr>, filter <list>, zoomed <lgl>

# data structure

Expand Down Expand Up @@ -223,9 +223,6 @@
Code
dm_for_filter_rev() %>% dm_filter(tf_1 = a < 8 & a > 3) %>% dm_get_tables() %>%
map(harmonize_tbl)
Condition
Warning:
Autoincrementing columns not yet supported for DuckDB, these won't be set in the remote database but are preserved in the `dm`
Output
$tf_6
# A tibble: 2 x 3
Expand Down