Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrated the updated fonts solution from https://github.com/cynkra/cy… #2233

Closed
wants to merge 1 commit into from

Conversation

maelle
Copy link
Member

@maelle maelle commented Sep 17, 2024

…nkraweb/issues/662

Same as #2199 but branch name allowing a preview thanks @krlmlr

Copy link
Contributor

aviator-app bot commented Sep 17, 2024

Current Aviator status

Aviator will automatically update this comment as the status of the PR changes.
Comment /aviator refresh to force Aviator to re-examine your PR (or learn about other /aviator commands).

This PR was closed without merging. If you still want to merge this PR, re-open it.


See the real-time status of this PR on the Aviator webapp.
Use the Aviator Chrome Extension to see the status of your PR within GitHub.

@krlmlr
Copy link
Collaborator

krlmlr commented Sep 23, 2024

@wael-sadek: Can you please help here? I have retriggered the job to refresh the deployment.

@maelle
Copy link
Member Author

maelle commented Sep 23, 2024

actually all good now 😅

@krlmlr
Copy link
Collaborator

krlmlr commented Sep 23, 2024

Do we still need this PR?

@maelle
Copy link
Member Author

maelle commented Sep 23, 2024

yes I mean the preview is good so it should be merged

@krlmlr
Copy link
Collaborator

krlmlr commented Sep 24, 2024

I applied be56e07 to the docs branch which bases directly off of v1.0.10 . The changes should be available on the main page after that.

Did you check main or /dev? The current preview doesn't show a difference, but the nightly build likely wiped the build from this PR.

Anyway, we'll see after https://github.com/cynkra/dm/actions/runs/11008275866 .

@krlmlr
Copy link
Collaborator

krlmlr commented Sep 24, 2024

All seems good to me. Merging manually, thanks!

@krlmlr krlmlr closed this Sep 24, 2024
@maelle
Copy link
Member Author

maelle commented Sep 24, 2024

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants